Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unix pipes with TCP sockets #231

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Replace unix pipes with TCP sockets #231

merged 3 commits into from
Mar 23, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Mar 19, 2020

Did you run make format && make check?
Yes
Fixes #230

Changes:

  • Now app module uses TCP sockets instead of unix pipes
  • Corresponding visor config field was changed
  • Tests are adapted

evanlinjin
evanlinjin suggested changes Mar 20, 2020
View reviewed changes
pkg/app/appcommon/config.go Outdated Show resolved Hide resolved
nkryuchkov
nkryuchkov suggested changes Mar 23, 2020
View reviewed changes
cmd/skywire-cli/commands/visor/gen-config.go Outdated Show resolved Hide resolved
cmd/skywire-visor/commands/root.go Outdated Show resolved Hide resolved
nkryuchkov
nkryuchkov approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jdknives jdknives merged commit 3ba933a into skycoin:develop Mar 23, 2020
@jdknives jdknives mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin requested changes

@nkryuchkov nkryuchkov nkryuchkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Darkren @evanlinjin @nkryuchkov @jdknives